-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add ability to build deb files on aarch64 #4762
Conversation
added support of aarch64 deb packets
updated fpm for building aarch64
so the problem of building x86 on aarch64 was in fpm. it has a bug in version prior to 1.13 (jordansissel/fpm#1775) I've fixed the workflow to install the latest fpm from ubuntu's repo and use it for building |
added using system fpm
I'm stuck with installing nvm in the container under aarch64. If anybody knows how to do that properly I will be really appreciated it. Or maybe somebody knows how to install specific version of nodejs without nvm? |
If I understand the intent of this PR correctly you would like to add arm64 architecture support to insomnia. Assuming that's the case it would be helpful to start locally and test it out before looking at github actions. Here's how this can be done using electron-builder. cd packages/insomnia
npm run build:app
BUILD_TARGETS=deb node_modules/.bin/electron-builder build --config electron-builder.config.js --arm64
|
@jackkav I've already built arm64 deb on my local machine. Everything works correctly. But I can not make it building in github action. The main problem, currently, is to install needed version of node. I can not install nvm in arm64 virtual machine in github actions. And I do not know other way to install the exact version of node needed for building the Insomnia |
The node version is 16.3.2, you don't need nvm to build we just use .nvmrc to track this version in our tooling. |
seems to be working node setup container on aarch64
fixed permissions bug with logs for npm
@jackkav
|
found a way how to install needed nodejs without nvm
trying to make npm working
@jackkav I've found a way how to install exact version of node without npm but now I have a problem which I can not solve by myself
I'm not a nodejs dev |
@jokaorgua I don't have an exact solution to your issue but I did face a similar problem when compiling using a Dockerfile and I had to change user to root. Also, glued together a script to compile for arm64, might give out a hint as to what's missing with your changes. Here it is - https://github.com/ParitoshBh/script-ions/tree/master/insomnia_arm64_deb |
Closed as stale. |
This PR is a draft.
I was able to add support of aarch64 containers for building the sources but I do not know how to add arm64 arch for building the packages.
Due to the logs of github actions it still builds x64 on aarch64
I need help with this.
I've checked out the insomnia on my ubuntu 20.04 ARM and ran it through
npm run dev
. Everything seems to be ok.Maybe someone could advise better solution for building the arm version of snap or deb files? Would be great