-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kong-att: Source 42-kong-envs.sh #74
base: master
Are you sure you want to change the base?
Conversation
|
I have reproduced the issue, but the patch does not seem to fix it. Can you try again yourself, deleting all docker images before you rebuild? |
So that the `--yml` argument can be used with `--tag` in addition to `--image`. Images created from tags, with Kong built from `make dev`, don't have the `kong` binary on the default `PATH` and other Lua environment variables set for non-interactive shells. This results in the following error: kong-3-0-0-kong-1 | /bin/kong-att: 7: /bin/kong-att: kong: not found kong-3-0-0-kong-1 | ln: failed to create symbolic link '/kong/servroot/logs/access.log': No such file or directory kong-3-0-0-kong-1 | ln: failed to create symbolic link '/kong/servroot/logs/admin_access.log': No such file or directory kong-3-0-0-kong-1 | ln: failed to create symbolic link '/kong/servroot/logs/error.log': No such file or directory kong-3-0-0-kong-1 | nginx: [alert] could not open error log file: open() "/kong/servroot/logs/error.log" failed (2: No such file or directory) kong-3-0-0-kong-1 | 2022/12/04 21:58:57 [emerg] 1#0: open() "/kong/servroot/nginx.conf" failed (2: No such file or directory) kong-3-0-0-kong-1 exited with code 1 It can be reproduced with this `kong.yml`: _format_version: "2.1" _transform: true services: - name: httpbin url: http://httpbin:80 routes: - name: httpbin paths: - / And these commands to build a new image: gojira up --tag 3.0.0 gojira run --tag 3.0.0 make dev gojira snapshot --tag 3.0.0 gojira up --tag 3.0.0 --yml kong.yaml The same steps should work, after deleting all Docker images/layers, when running from this branch/commit.
a6fc722
to
359d709
Compare
Thanks for testing the patch. I assume that I got a dependency error like this?
I think that I must have taken a manual snapshot after running I've adjusted the commands in the PR description and also corrected the As a sidenote, I originally thought about it when opening this PR but it's even more relevant now, it would be great to setup some CI tests for common workflows. Is that of interest? Would an initial PR be accepted if a maintainer does the remaining setup? |
So that the
--yml
argument can be used with--tag
in addition to--image
. Images created from tags, with Kong built frommake dev
, don't have thekong
binary on the defaultPATH
and other Lua environment variables set for non-interactive shells. This results in the following error:It can be reproduced with this
kong.yml
:And these commands to build a new image: