fix: fixed mixed-types array generation for req-validator plugin #231
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/validate-for-cookie-presence #231 +/- ##
====================================================================
+ Coverage 69.05% 69.23% +0.18%
====================================================================
Files 24 24
Lines 3351 3361 +10
====================================================================
+ Hits 2314 2327 +13
+ Misses 864 862 -2
+ Partials 173 172 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Tieske
approved these changes
Nov 25, 2024
Prashansa-K
merged commit 7f23c19
into
fix/validate-for-cookie-presence
3 checks passed
Prashansa-K
added a commit
that referenced
this pull request
Nov 25, 2024
* fix: validating cookie parameter for req-validator At the moment, we do not support cookie parameters in request-validator plugin. However, `deck file openapi2kong` command generates the yaml file even if it is present in the parameter schema. Thus, adding a validation layer over it to ensure deck does not create invalid specs. For: #223 * fix: validating cookie parameter for req-validator At the moment, we do not support cookie parameters in request-validator plugin. However, `deck file openapi2kong` command generates the yaml file even if it is present in the parameter schema. Thus, adding a validation layer over it to ensure deck does not create invalid specs. For: #223 * fix: fixed log message for cookie params * fix: fixed mixed-types array generation for req-validator plugin (#231) * fix: fixed mixed-types array generation for req-validator plugin * fix: reverted final return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to FTI: https://konghq.atlassian.net/browse/FTI-6357
For: #230