Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCU-1570] Improve README #2969

Merged
merged 12 commits into from
Jun 28, 2021
Merged

[DOCU-1570] Improve README #2969

merged 12 commits into from
Jun 28, 2021

Conversation

falondarville
Copy link
Contributor

Review

@Kong/team-docs

Summary

  • Add MIT and contributor badges
  • Improve introduction text by adding listed key info
  • Clean up run instructions for Docker, gulp, and npm
  • Add section for plug-in contributors to grab a badge
  • Add note that "Generate the PDK, Admin API, CLI, and Configuration documentation" section is for source code maintainers

Reason

  • Help get new contributors up-and-running faster
  • Reward plug-in contributors with a copy-and-paste-able badge
  • Clarify any confusion about intended audience for each section

Addresses: Issues #809 and #1030

Testing

Tested locally via Atom Markdown previewer.

@falondarville falondarville requested a review from a team as a code owner June 25, 2021 21:46
README.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for kongdocs ready!

🔨 Explore the source changes: bbd05ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/kongdocs/deploys/60da4531c7b32700079b922f

😎 Browse the preview: https://deploy-preview-2969--kongdocs.netlify.app

README.md Outdated Show resolved Hide resolved
README.md Outdated

If you're making more than a small typo or grammar change, we ask that you pull down the repository and build locally.
* **Our _Admin API_ docs are auto-generated**. That means that all PRs for ADMIN API should be open over at the [Kong/kong](https://github.com/Kong/kong) repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit more than just the admin API docs. Here's the full list:

Gateway OSS:

For gateway OSS, open PRs against Kong/kong.

Gateway Enterprise:
Just the configuration reference (https://docs.konghq.com/enterprise/2.4.x/property-reference/)

For Gateway Enterprise, they should open a docs issue and we'll update the kong-ee repo (not publicly accessible).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Falon Darville and others added 6 commits June 28, 2021 10:34
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo and a small phrasing suggestion, otherwise LGTM!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Falon Darville and others added 2 commits June 28, 2021 14:54
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
@falondarville falondarville merged commit 92664e3 into main Jun 28, 2021
@falondarville falondarville deleted the docu-1570 branch June 28, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants