add KONG_CLUSTER_CERT and KONG_CLUSTER_CERT_KEY value #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value via environment variables
|
I think we should certainly add support for something like this to Kong - it has been long overdue. But, this is the wrong place for it. If we were to merge this, it would be the first instance of "docker kong has additional KONG_ that other setups don't" where other setups are non-docker based deployments of Kong. And that goes against Kong's principle of running everywhere and anywhere. |
|
xref Kong/kong#9253 |
hutchic
suggested changes
Aug 29, 2022
|
related #469 |
|
Closing, looking forward to #469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to configure KONG_CLUSTER_CERT and KONG_CLUSTER_CERT_KEY value via environment variables