Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kong): add RBAC rules for listing namespaces when gateway API is detected #974

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(kong): add RBAC rules for listing namespaces when gateway API is detected #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f412d1e
fix(kong): add RBAC rules for listing namespaces when gateway API is …
pmalek Dec 12, 2023
5119a1a
kong: add watch permissions to ClusterRole
pmalek Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions charts/kong/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Unreleased

### Fixed

* Add RBAC rules for get, list and watch operations on namespaces so that Gateway API
controllers in KIC can access using a cached controller-runtime client.
[#974](https://github.com/Kong/charts/pull/974)

## 2.33.2

* Fix a template bug related to the `affinity` field for migrations Pods.
Expand Down
9 changes: 8 additions & 1 deletion charts/kong/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,6 @@ Kubernetes namespace-scoped resources it uses to build Kong configuration.

Collectively, these are built from:
kubectl kustomize github.com/kong/kubernetes-ingress-controller/config/rbac?ref=main
kubectl kustomize github.com/kong/kubernetes-ingress-controller/config/rbac/knative?ref=main
kubectl kustomize github.com/kong/kubernetes-ingress-controller/config/rbac/gateway?ref=main

However, there is no way to generate the split between cluster and namespaced
Expand Down Expand Up @@ -1675,6 +1674,14 @@ Kubernetes Cluster-scoped resources it uses to build Kong configuration.
verbs:
- get
- update
- apiGroups:
- ""
resources:
- namespaces
verbs:
- get
- list
czeslavo marked this conversation as resolved.
Show resolved Hide resolved
- watch
{{- end }}
- apiGroups:
- networking.k8s.io
Expand Down
Loading