Additional fixes for FDISK after the migration to SDCC 4.2 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assembler functions now return values iin DE, not HL; so CallFunctionInExtraBank is modified accordingly. - Bank 5 code and bank 6 code were sharing the same RAM and this was causing issues, now they use different RAM areas. - Apply "chmod +x" to the mknexrom tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#115 converted the C sources to the new calling convention introduced in SDCC 4.2 (passing arguments to functions in registers instead of in the stack) and #117 implemented additional fixes, but there were still some bugs that prevented FDISK from working properly:
CallFunctionInExtraBankneeded to be adjusted.makefileneeded changes to use different RAM areas.This pull request fixes these issues and as a bonus,
chmod +xis applied to to themknexromtool.