-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Shaderc to tests in order to enable online shader builds #153
Conversation
After further assessment the decision is to go ahead with glslang #154 - the main reason is as this significantly reduces compilation times massively, as well as the maintenance burden, whilst providing the same base functionality as core. This means that the initial implementation won't have thread-safe support, however it will still support the |
Edit: Decision was to go with #154
Fixes #150
Fixes #121
Aims to add shaderc in tests as dependency to enable all current tests to work in the CI.
This was also an attempt to explore whether shaderc could be adopted as a dependency, but it seems that shaderc has too many dependencies, including glslang, glslc, spirv-tools and many others. This increases the binary of the tests from 3mb to 11mb which is quite significant.
The existing PR #112 adds support only to GLSLang compiler from Khronos group, and seems to only add 2-3 mb, and only requires a single dependency making it more appealing. @alexander-g suggests that pyshaderc is faster to compile, but it seems that shaderc is based on glslc and hence glslang so it may be worth exploring further as it may be more feasible to just add glslang instead.
Outstanding:
char
and replace byuint32_t
for inputs to data