-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added further tests to CI and provide Dockerimage with builds to swiftshader #119
Conversation
Consider adding |
Interesting @alexander-g, good idea, that could provide full coverage of the tests, let me give it a shot |
What's the reasoning behind this? Numpy is de-facto standard in anything computing related. |
@alexander-g the module was failing to import if the numpy dependency was not present, so I added it to setup.py - it's mainly to assess whether there would be users who would like to install Kompute without numpy to minimise dependencies. I do agree that numpy is the defacto standard in python so should make sense to have it by default. |
Just looking at PyShaderc it doesn't look like it's currently maintained (no updates since 2017), so not sure adding it as a dependency. I am continuously surprised the lack of tools / utilities around GPGPU workflows, particularly around Python - let me give it some thought, as I would rather take in something along the lines of a simple GLSL utility function that is limited but maintained than bringing in packages that don't have too much support. Thinking outloud on this, I had a few interactions with the author of https://github.com/pygfx/pyshader - it may actually be a good opportunity for them to adopt some of these functionalities. |
Yes it's not maintained any more but it's supposed to be only a dependency for tests, not for the end user. |
That's technically correct, but currently large number of users would use the tests for guidance on how to use the library (that's largely how pybind11 provides insights to more advanced usage, by pointing users to the unit tests) - having said that, I think if there is a way to explore a more active project like pyshader to offer these functionalities. Let me reach out to the pyshader project, as that would be the ideal, but if that's not an option I think pyshaderc is still a good choice to get further coverage of tests. |
Updated docs https://kompute.cc/overview/ci-tests.html |
Added #121 to ensure the rest of the tests are covered |
Extended work on #114
PR includes:
Outstanding (to cover in PR or open respective issues):