Fix building shaders on native linux #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting @aliPMPAINT, thanks for the contribution! |
|
@axsaucedo Thank you for making this project happen. |
|
Yes - worked like a charm, thanks again @aliPMPAINT.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you enable the
KOMPUTE_OPT_BUILD_SHADERS=1on cmake, shaders will fail to build, as "/c/VulkanSDK/1.2.141.2/Bin32/glslangValidator.exe" is chosen as the default binary, which in non-existance on native linux. What has been done if it's not windows, it'll check whether it's WSL or native linux and will choose the appropriate binary, "/c/VulkanSDK/1.2.141.2/Bin32/glslangValidator.exe" for WSL and "/usr/bin/glslangValidator" for Linux.Gonna be honest, I haven't tested it on windows or WSL, but it should work, hopefully