fix(cosmos): fix tx broadcasting error #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
upgrade-cosmos-dep
branch
from
c9ac682
to
f4ba695
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
upgrade-cosmos-dep
branch
from
f4ba695
to
c4aa131
Compare
smk762
previously approved these changes
Oct 10, 2024
borngraced
previously approved these changes
Oct 10, 2024
|
@onur-ozkan can you please fix the conflicts in cargo.lock due to merging the solana removal PR. |
… into upgrade-cosmos-dep
Done. |
shamardy
approved these changes
Oct 10, 2024
onur-ozkan
added a commit
that referenced
this pull request
Oct 16, 2024
This commit upgrades cosmrs to version 15 along with other required dependency upgrades to fix the broadcast_tx_commit failure.
dimxy
added a commit
that referenced
this pull request
Oct 17, 2024
* dev: fix(cosmos): fix tx broadcasting error (#2238) chore(solana): remove solana implementation (#2239) chore(cli): remove leftover subcommands from help message (#2235) fix(orders): fix cancel order race condition using time-based cache (#2232) fix(legacy-swap): taker failed spend maker payment marked as failed (#2199) chore(adex-cli): deprecate adex-cli (#2234) feat(new-RPC): connection healthcheck implementation for peers (#2194) fix(proxy-signature): add message lifetime overflows (#2233) feat(CI): handle remote files in a safer way (#2217) chore(doc): update issue address in README (#2227) fix(merge): remove duplicated db_root function (#2229) feat(wallets): add `get_wallet_names` rpc (#2202) chore(tests): don't use `.wait()` and use `block_on` instead (#2220) fix(native-rpc): remove escaped response body (#2219) fix(clippy): fix coins mod clippy warnings in wasm (#2224) feat(core): handling CTRL-C signal with graceful shutdown (#2213) docs(README): fix typos (#2212) remove the non-sense arguments (#2216) fix(db): stop creating the all-zeroes dir on KDF start (#2218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nodes do not include
deliver_txin theirbroadcast_tx_commitresponses andcosmrs@14isn't compatible with that.This is what we get when KDF invokes
broadcast_tx_commit:This PR upgrades
cosmrsto version 15 along with other required dependency upgrades to fix thebroadcast_tx_commitfailure.