Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI flows for adex-cli #1818

Merged
merged 4 commits into from
May 12, 2023
Merged

add CI flows for adex-cli #1818

merged 4 commits into from
May 12, 2023

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented May 11, 2023

blocker for #1768

Signed-off-by: ozkanonur <[email protected]>
shamardy
shamardy previously approved these changes May 12, 2023
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these important checks!

#1768 added some unit tests for CLI so we will need to add adex-cli unit tests CI checks too after the PR is merged.

Please also fix the merge conflicts related to the changelog file :)

@onur-ozkan
Copy link
Member Author

Added new pipeline for cargo test

Cargo.toml Show resolved Hide resolved
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit f8ada95 into dev May 12, 2023
@shamardy shamardy deleted the adex-cli-ci-flows branch May 12, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants