Fix hanging pointers #1158 #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add 'SharedRc' and 'WeakRc' that can be used to debug hanging pointers * Move 'MmCtx::stop' to 'MmArc::stop' * Replace 'Arc<MmCtx>' with 'SharedRc<MmCtx>'
|
@SirSevenG could you please check if you can log in to the same account in 30s? |
|
@sergeyboyko0791 "Test MM2" stage failed on CI. Please run tests before opening the PR and track the status afterward to ensure that CI build passed successfully. |
SirSevenG
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Used latest build from here http://195.201.0.6/fix-hanging-pointers/ and add-logout-to-top-menu branch of air dex.
Tested cases:
- Switch to and fro 2 different wallets in lees than 30s - failed, database error.
- Switch between 2 wallets with the same seed - failed, database error.
- Switch to and fro 2 different wallets in 60+ s - worked correctle with no issues.
While 1 and 2 are expected, 3 proves that pointers issue should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedRcandWeakRcthat can be used to debug hanging pointersMmCtx::stoptoMmArc::stopArc<MmCtx>withSharedRc<MmCtx>To run mm2 with pointer tracker, run
We also can add a test that checks if all
MmArcpointers are released in 30s.