Skip to content

Commit

Permalink
fix: build linux x86-64 with reasonable glibc (#1733)
Browse files Browse the repository at this point in the history
* use `ubuntu-18.04` for dev and release builds

Signed-off-by: ozkanonur <[email protected]>

* always cancel previous `in-progress` pipelines when new commit pushed

Signed-off-by: ozkanonur <[email protected]>

* switch from `ubuntu-latest` to `ubuntu-18.04` for all builds

Signed-off-by: ozkanonur <[email protected]>

* turn off share generics nightly feature

Signed-off-by: ozkanonur <[email protected]>

* set JEMALLOC environments in CI

Signed-off-by: ozkanonur <[email protected]>

* rollback jemalloc entry from changelog

Signed-off-by: ozkanonur <[email protected]>

---------

Signed-off-by: ozkanonur <[email protected]>
Reviewed-by: shamardy <[email protected]>
  • Loading branch information
onur-ozkan authored Mar 24, 2023
1 parent 4d691ca commit 759d180
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .cargo/config
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[env]
JEMALLOC_SYS_WITH_MALLOC_CONF = "percpu_arena:percpu,oversize_threshold:0,background_thread:true,metadata_thp:auto,dirty_decay_ms:5000,muzzy_decay_ms:5000"
JEMALLOC_SYS_WITH_MALLOC_CONF = "background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto"

[target.'cfg(all())']
rustflags = [ "-Zshare-generics=y" ]
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/dev-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,19 @@ on:
branches:
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
MANUAL_MM_VERSION: true
JEMALLOC_SYS_WITH_MALLOC_CONF: 'background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto'

jobs:
linux-x86-64:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -193,7 +198,7 @@ jobs:

wasm:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -281,7 +286,7 @@ jobs:

android-aarch64:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -329,7 +334,7 @@ jobs:

android-armv7:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -380,7 +385,7 @@ jobs:
if: github.event_name != 'pull_request'
needs: linux-x86-64
timeout-minutes: 15
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/fmt-and-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
- main
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
fmt-and-lint:
timeout-minutes: 45
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,19 @@ on:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
MANUAL_MM_VERSION: true
JEMALLOC_SYS_WITH_MALLOC_CONF: 'background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto'

jobs:
linux-x86-64:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -188,7 +193,7 @@ jobs:

wasm:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -276,7 +281,7 @@ jobs:

android-aarch64:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down Expand Up @@ -324,7 +329,7 @@ jobs:

android-armv7:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v3
- name: Install toolchain
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
- main
- dev

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
FROM_SHARED_RUNNER: true

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/virustotal_scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
release:
types: [created, edited, released, published]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
virustotal:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
- CI/CD migrated from Azure to Github runners [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- CI tests are much stabilized [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Integration and unit tests are seperated on CI stack [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Jemalloc configuration updated for optimization purposes [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Codebase is updated in linting rules at wasm and test stack [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- `crossbeam` bumped to `0.8` from `0.7` [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
- Un-used/Unstable parts of mm2 excluded from build outputs which avoids mm2 runtime from potential UB [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)
Expand Down

0 comments on commit 759d180

Please sign in to comment.