Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ATOM blocktime #554

Closed
wants to merge 1 commit into from
Closed

fix ATOM blocktime #554

wants to merge 1 commit into from

Conversation

cipig
Copy link
Member

@cipig cipig commented Nov 8, 2022

block time is 7 seconds, not 7 minutes: https://www.mintscan.io/cosmos

@tonymorony tonymorony marked this pull request as draft November 8, 2022 16:17
@tonymorony
Copy link

tonymorony commented Nov 8, 2022

it's a different field which actually using by API https://github.com/KomodoPlatform/air_dex/pull/677#issuecomment-1294829741
P.S. it's quite confusing CC [ @ozkanonur @artemii235 ]

@tonymorony tonymorony closed this Nov 8, 2022
@cipig
Copy link
Member Author

cipig commented Nov 8, 2022

PLG20 has "avg_blocktime": 0.03
ERC20 has "avg_blocktime": 0.25
so for ATOM this value means something different?

@tonymorony
Copy link

tonymorony commented Nov 8, 2022

avg_blocktime != avg_block_time
we can actually rename avg_blocktime (which I've added couple years ago with intention to improve swap duration estimates in the interfaces) to make it less confusing because it's not using anywhere yet afaik

@onur-ozkan
Copy link
Member

P.S. it's quite confusing CC [ @ozkanonur @artemii235 ]

I agree. But seems like it's not a blocker for anything. I will fix the confusion in KomodoPlatform/komodo-defi-framework#1526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants