Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add Briskcoin (BKC) into Komodo Dex #1204

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Briskcoin-official
Copy link

Request to add Briskcoin (BKC) into Komodo Dex

It is BKC ticker but BCK ticker is already existing so i put BKC1
BKC1 (default ticker is BKC)
BCK1 (Default Ticker BKC)
BKC1 (Default Ticker BKC)
BKC1 (Default Ticker BKC)
@cipig
Copy link
Member

cipig commented Dec 3, 2024

there is already a coin with same ticker in coins file:

  { 
    "coin": "BKC",
    "name": "bunkercoin",
    "fname": "Bunkercoin",
    "sign_message_prefix": "Bunkercoin Signed Message:\n",
    "rpcport": 22555,
    "pubtype": 25,
    "p2shtype": 22,
    "wiftype": 158,
    "txfee": 1000000,
    "force_min_relay_fee": true,
    "dust": 1000000,
    "mm2": 1,
    "required_confirmations": 10,
    "avg_blocktime": 60,
    "protocol": {
      "type": "UTXO"
    },
    "derivation_path": "m/44'/3'",
    "links": {
      "github": "https://github.com/bunkercoin/bunkercoin",
      "homepage": "https://bunkercoin.org"
    } 
  },

afaik it's dead, so could be delisted, but till then adding a new coin with same ticker will not work
btw, your PR is missing the entry to coins file completely

logo needs to have the same name as ticker, bkc.png... same with all other files... the electrum config needs the same file name as the ticker, else the correct config is not found

@Briskcoin-official
Copy link
Author

Briskcoin-official commented Dec 3, 2024 via email

@cipig
Copy link
Member

cipig commented Dec 3, 2024

Please provide the missing entry file path. We will update accordingly.

not sure what you mean... the coins file is in the main directory: https://github.com/KomodoPlatform/coins/blob/master/coins
but, as i said, there can't be 2 coins with same ticker

@Briskcoin-official
Copy link
Author

Briskcoin-official commented Dec 3, 2024 via email

@cipig
Copy link
Member

cipig commented Dec 3, 2024

@Briskcoin-official
Copy link
Author

Briskcoin-official commented Dec 3, 2024 via email

@cipig
Copy link
Member

cipig commented Dec 3, 2024

Please join BKC discord group.

i can't, since i reached the limit of max. discords i can join

@Briskcoin-official
Copy link
Author

Briskcoin-official commented Dec 3, 2024 via email

@Briskcoin-official
Copy link
Author

Briskcoin-official commented Dec 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants