Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/tendermint coins #1143

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Add/tendermint coins #1143

wants to merge 15 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 16, 2024

This PR adds a few hundred TENDERMINT and TENDERMINTTOKEN coins to the repo.
All info was sourced via https://cosmos.directory/ APIs from https://github.com/cosmos/chain-registry

As this data changes often, I'd like to include the parsing script functions into the CI workflow once the validity of its output has been tested and proven accurate.

I'll test activation and wallet functions for as many as I can source funds for, and perhaps limit the new listings to those until later when requested or able to be tested.

@smk762 smk762 marked this pull request as draft September 16, 2024 15:41
@cipig
Copy link
Member

cipig commented Nov 14, 2024

there are a couple of duplicates in this PR
you can see it on the changes of icons... BAND is eg overwritten by something else, CRO too
i fear those tickers are also overwritten by new ones, which would be bad
also see that USDT icon is replaced and USDC... we should not overwrite any icons, the existing ones are carefully selected
what about the files in icons? those are actually created by the script, but the PR over/writes those too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants