Actually replace updated images.

Komodo5197 · May 17, 2024 · 0ecbb69 · 0ecbb69
1 parent 4df3af2
commit 0ecbb69
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/lib/models/jellyfin_models.dart b/lib/models/jellyfin_models.dart
@@ -2278,6 +2278,9 @@ class BaseItemDto with RunTimeTickDuration {
         other.albumArtist == albumArtist &&
         other.childCount == childCount &&
         other.imageId == imageId &&
+        // imageId does not necessarily change when the image is updated, so
+        // we must compare blurHashes as well.
+        other.blurHash == blurHash &&
         other.mediaSources?.length == mediaSources?.length &&
         other.mediaStreams?.length == mediaStreams?.length &&
         other.normalizationGain == normalizationGain &&

diff --git a/lib/services/downloads_service.dart b/lib/services/downloads_service.dart
@@ -2,10 +2,10 @@ import 'dart:async';
 import 'dart:collection';
 import 'dart:io';
 
-import 'package:background_downloader/background_downloader.dart';
-import 'package:collection/collection.dart';
 import 'package:Finamp/components/global_snackbar.dart';
 import 'package:Finamp/services/jellyfin_api_helper.dart';
+import 'package:background_downloader/background_downloader.dart';
+import 'package:collection/collection.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_gen/gen_l10n/app_localizations.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';

diff --git a/lib/services/downloads_service_backend.dart b/lib/services/downloads_service_backend.dart
@@ -13,6 +13,7 @@ import 'package:isar/isar.dart';
 import 'package:json_annotation/json_annotation.dart';
 import 'package:logging/logging.dart';
 import 'package:path/path.dart' as path_helper;
+import 'package:uuid/uuid.dart';
 
 import '../models/finamp_models.dart';
 import '../models/jellyfin_models.dart';
@@ -1592,9 +1593,8 @@ class DownloadsSyncService {
           path_helper.join(downloadLocation.currentPath, subDirectory);
     }
 
-    // We still use imageIds for filenames despite switching to blurhashes as
-    // blurhashes can include characters that filesystems don't support
-    final fileName = "${_filesystemSafe(item.imageId)!}.image";
+    // Always use a new, unique filename when creating image downloads
+    final fileName = "${const Uuid().v4()}.image";
 
     _isar.writeTxnSync(() {
       DownloadItem? canonItem =