fix: Reduce MQTT publishing by excluding debug logging from bridge/logging
#22066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drastically reduces MQTT publishing by preventing
debuglogging being logged tobridge/logging. This became especially important after Koenkk/zigbee-herdsman#989 since now all zigbee-herdsman logging is also being published.Note after this
debuglogging will also not show up in the frontend anymore, but given it only shows 100 lines, it was not useful fordebuglogging anyway.CC: @Nerivec @nurikk @kirovilya
@corporategoth @mundschenk-at I hope this also improves #20648 a bit
TODO:
bridge/loggingdocs zigbee2mqtt.io#2676