Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set entity category to configuration for Sonoff TRVZB open/close degree entities #7573

Merged
merged 1 commit into from
May 30, 2024

Conversation

blacknell
Copy link
Contributor

@blacknell blacknell commented May 29, 2024

Closes #7564

Currently, the entity category is not set for open and close degree meaning the controls display in dashboards and elsewhere in HA. These should be configuration entities managed through admin UI.

@blacknell blacknell changed the title Set device class to configuration for Sonoff TRVZB for open/close degree Set entity category to configuration for Sonoff TRVZB for open/close degree May 29, 2024
@blacknell blacknell changed the title Set entity category to configuration for Sonoff TRVZB for open/close degree Set entity category to configuration for Sonoff TRVZB open/close degree entities May 29, 2024
@Koenkk Koenkk merged commit e7ca0f8 into Koenkk:master May 30, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented May 30, 2024

thanks!

@blacknell blacknell deleted the fix/sonoff-trv-devcategory branch June 1, 2024 10:41
@blacknell
Copy link
Contributor Author

@Koenkk - I've since noticed a whole bunch more sensor entities that seem to me "useless" to the average end user. I think they should move to be diagnostic category rather than default sensor category. Their function isn't documented anywhere by Sonoff.

I have 14 TRV's so that's 56 entities that get added to auto dashboards which is silly.

If you're in broad agreement I'll create a fresh PR and submit that (move them to diagnostic).

They are:-

  • Closing steps
  • Valve closing limit voltage
  • Valve motor running voltage
  • Valve opening limit voltage

There's also a read-only sensor called Frost Protection Temperature that is by default disabled but listed as a Sensor. But this is superfluous as it just reflects (if enabled) the value of the writeable control entity of the same name. I could investigate this and find out why it's duplicated and remove.

@Koenkk
Copy link
Owner

Koenkk commented Jul 15, 2024

If you're in broad agreement I'll create a fresh PR and submit that (move them to diagnostic).

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonoff TRVZB attributes are not marked with device_category as configuration entities
2 participants