Add pm25/air quality support to IKEA STARKVIND #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately it looks like we can't configure reporting for this attribute. The value is not update when the device is not running. The user can manualy poll the value.
Koenkk
reviewed
Nov 12, 2021
Koenkk
reviewed
Nov 12, 2021
|
@Koenkk question about the the precision option, can I set the default to 2 for the device? Or is that always 0 ? I'm OK with either but the device supports up to 2 |
|
If the default is 2, please set the default to 2. |
Yes, but how? It's not obvious to me where to set the default. |
|
Does it work after adding zigbee-herdsman-converters/lib/utils.js Line 75 in 1ad7e28 |
|
That seems to work, that will effect other pm25 sensors like the heiman ones too right? |
sjorge
added a commit
to sjorge/zigbee-herdsman-converters
that referenced
this pull request
Nov 12, 2021
Koenkk
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Revert "Add pm25/air quality support to IKEA STARKVIND E2007 (#3338)" This reverts commit 1ad7e28. * Add fz.ikea_air_purifier * Add tz.ikea_air_purifier_* * Update STARKVIND expose data * Update STARKVIND reporting * Fix lint * Rework STARKVIND to custom fan_mode/fan_state * Rename filterOperationTime to filterRunTime * Use value from filterLifeTime * Report filterRunTime once an hour filterRunTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting for this cluster doesn't seem to work, it returns INVALID_DATA.
From what I gather from the various discussions over at the z2m repo is that the app will poll the value when viewing the device. The value also only updates when the fan is running, if the fan is off after a while the value will return 65535 indicating the current value is not known.
Edit: I assume we should update the notes for the device to indicate that the value needs to be manual refreshed and it's quirks?