Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed async functionality. Updated README #13

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Conversation

ioannis-kody
Copy link
Contributor

@ioannis-kody ioannis-kody commented Dec 11, 2024

Associated JIRA tasks

BAM-135

What the code does.

  • Removed async functionality to simplify samples
  • Updated README to include all requests and responses with examples.

Does this code change break backwards compatibility?.

Describe where and how this code change breaks backwards compatibility.

@ioannis-kody ioannis-kody requested a review from a team as a code owner December 11, 2024 17:16
@sishbi
Copy link
Contributor

sishbi commented Dec 12, 2024

What the code does.
Describe what the code change is and what functionality it adds.

@ioannis-kody Please make sure to fill in the PR template 😄

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Simon Billingsley <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@sishbi sishbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start!
Some changes needed 😄

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ioannis-kody and others added 2 commits December 12, 2024 17:05
Co-authored-by: Simon Billingsley <[email protected]>
Copy link
Contributor

@sishbi sishbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioannis-kody ioannis-kody merged commit 6193803 into main Dec 13, 2024
2 checks passed
@ioannis-kody ioannis-kody deleted the updateClients branch December 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants