Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snackbar components for displaying messages about app processes #68

Open
nicomni opened this issue Jul 15, 2019 · 4 comments · May be fixed by #226
Open

Make snackbar components for displaying messages about app processes #68

nicomni opened this issue Jul 15, 2019 · 4 comments · May be fixed by #226
Labels
feature New feature or request

Comments

@nicomni
Copy link
Contributor

nicomni commented Jul 15, 2019

For example when an API call fails

See Material UI example
@nicomni nicomni added the feature New feature or request label Jul 15, 2019
@FredrikAugust
Copy link
Contributor

Good idea.

@erikskaar
Copy link
Contributor

An implementation of snackbars have been made in feature/snackbar where it can be seen when either adding a transaction or trying to add a transaction with too many characters. Is this close to what you had in mind?

@FredrikAugust
Copy link
Contributor

I believe this is exactly what was intended. Will try to review your PR now.

@FredrikAugust
Copy link
Contributor

Oh, the PR isn't out. Could you ping me when it is?

Btw, you can add "Closes #68" to the description of a PR (or in the commit message) to automagically close this issue when the PR is merged.

@erikskaar erikskaar linked a pull request Jan 28, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a snackbar to notify the user of important events Kodeworks/budsjetteringssystem
3 participants
@FredrikAugust @nicomni @erikskaar