Some optimizations on image.c buffer and stb_image to use less memory. #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to load some larger png, but still have some limitations.
When stb_image runs out of allocated memory, it asks to reallocate the double it had before. It quickly runs out when loading larger files. Changed it to realloc a fixed amount, saving some memory in the process.
Made some changes to image.c realloc to just append data in case the pointer being reallocated is the same as the last one allocated (as it is most of the times when loading images).
It also prevents some crashes by avoiding memcpy in case there is no more memory available.
Kind of related to #407 and #408, but didn't solve the problem completely.