-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CompilerDefines fields #1010
Conversation
That's a very "for my use only" pull request :-P |
This is more |
HaxeFoundation/haxe#5002 is fixed, so Kha probably broken with current behavior, so i complete this thing. |
I fixed it so much, it will never ever be a problem again (also added an updates.md and referenced this pull request in there). |
I mostly interested in this class for window name instead of default: |
I don't think the Window title should be a define, just pass it manually. |
That's sad, then this line should be removed https://github.com/Kode/khamake/blob/master/src/main.ts#L120 |
But using that line you can write some code which sets the window title to the project name. |
But you say that this should not be a define :) If you fine with define in khamake then i'm good, but i can also add this define manually in khafile, without khamake dependency. |
It's already there and today I don't feel like removing more things. |
No description provided.