This repository has been archived by the owner on Nov 17, 2018. It is now read-only.
Add support for canary/ptb webhooks #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you login through a canary client (or the site) and generate a Webhook, you get something like
https://canary.discordapp.com/api/webhooks/<channel snowflake>/<stuff>.You get a similar result on ptb client too, just with
ptb.instead ofcanary..While throwing
canary.orptb.from domain doesn't affect its functionality (it works the same), I prefer to keep webhooks on the domain I get them from as they still work, and this causes Jenkins to nag me and throw a error even though it works perfectly fine when I save it and try it out.This PR adds support for ptb and canary webhooks to finally end the nag.