Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSON export #26

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Fixed JSON export #26

merged 2 commits into from
Mar 25, 2023

Conversation

GoComputing
Copy link
Contributor

Added serialization to the classes 'ChatStore' and 'Messages' so that they can be JSON serialized.

Added serialization to the classes 'ChatStore' and 'Messages' so that they can be
JSON serialized.
@KnugiHK KnugiHK self-requested a review January 30, 2023 10:52
@KnugiHK KnugiHK added the bug Something isn't working label Jan 30, 2023
@velecto1
Copy link

Hey, how can I try this, please?

I've just noticed this pull request after making the issue #37.

I've already put your new lines into my repository and I've run sudo pip install '.[android_backup]' but I am still getting the same error message when running wtsexporter :(

@GoComputing
Copy link
Contributor Author

GoComputing commented Mar 24, 2023 via email

@velecto1
Copy link

Thank you, Carlos. Apparently, I was installing the original code GitHub repository as I left its URL i setup.py.

Copy link

@velecto1 velecto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that the bugfix works; thank you, Carlos!

I don't really understand the purpose of commenting out create_html(...) on line 187 in __main__.py, but everything seems to work, including the creation of HTML files.

@KnugiHK
Copy link
Owner

KnugiHK commented Mar 24, 2023

I've checked that the bugfix works; thank you, Carlos!

I don't really understand the purpose of commenting out create_html(...) on line 187 in __main__.py, but everything seems to work, including the creation of HTML files.

You mean even if create_html() is commented, the creation of HTML files still works?

@GoComputing
Copy link
Contributor Author

GoComputing commented Mar 24, 2023 via email

Copy link
Owner

@KnugiHK KnugiHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment line 187 in __main__.py

@KnugiHK
Copy link
Owner

KnugiHK commented Mar 24, 2023

I am so sorry, I shouldn't. I did when testing, and I forgot to remove it. How can I make it correct? Should I create a new pull request?

I am not really sure, but I requested change and maybe you can uncomment it in your branch and maybe the new commit will be reflected in this pull?

@GoComputing
Copy link
Contributor Author

I am so sorry, I shouldn't. I did when testing, and I forgot to remove it. How can I make it correct? Should I create a new pull request?

I am not really sure, but I requested change and maybe you can uncomment it in your branch and maybe the new commit will be reflected in this pull?

I uncommented the line and pushed. Now it is visible in the fix. Hope this is it.

Copy link
Owner

@KnugiHK KnugiHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KnugiHK KnugiHK merged commit 430a5ec into KnugiHK:dev Mar 25, 2023
@KnugiHK
Copy link
Owner

KnugiHK commented Mar 25, 2023

I also added a check before serialize the latest data model, so that the it is compatible with old model.

@KnugiHK KnugiHK added pending for release Feature or bug fix to be released and removed pending for release Feature or bug fix to be released labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants