fix: allowed output file protocols on Windows #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpozzi
requested review from
PedroTroller,
AntoineLelaisant and
AntoineGonzalez
AntoineLelaisant
previously approved these changes
Sep 13, 2023
PedroTroller
requested changes
Sep 13, 2023
alexpozzi
force-pushed
the
fix/windows-allowed-protocols-issue
branch
2 times, most recently
from
8f2e9e3
to
e29a3f0
Compare
alexpozzi
force-pushed
the
fix/windows-allowed-protocols-issue
branch
from
e29a3f0
to
63f18db
Compare
alexpozzi
requested review from
PedroTroller and
AntoineLelaisant
and removed request for
AntoineGonzalez
AntoineLelaisant
approved these changes
Sep 13, 2023
PedroTroller
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489