Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code of conduct and link to it in contributing file #386

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

eveyonline
Copy link
Member

No description provided.

Copy link
Member

@alexpozzi alexpozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!
Thank you for contributing! 🎉
I left you just a little comment 😉

CONTRIBUTING.md Outdated
Comment on lines 3 to 5
:+1: First of all, thanks for contributing! The team is happy to help if you have any questions. Have a look to this contributing guide and also to the [FAQ section](https://github.com/KnpLabs/snappy/blob/master/doc/faq.md). :feet: And also to our [Code of Conduct](https://github.com/KnpLabs/snappy/blob/master/CODE_OF_CONDUCT.md)

The following is a set of guidelines for contributing to Snappy, which is hosted in the [KNP Labs Organization](https://github.com/KnpLabs) on GitHub. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request. :shipit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about putting the code of conduct instructions in a different chapter?

Suggested change
:+1: First of all, thanks for contributing! The team is happy to help if you have any questions. Have a look to this contributing guide and also to the [FAQ section](https://github.com/KnpLabs/snappy/blob/master/doc/faq.md). :feet: And also to our [Code of Conduct](https://github.com/KnpLabs/snappy/blob/master/CODE_OF_CONDUCT.md)
The following is a set of guidelines for contributing to Snappy, which is hosted in the [KNP Labs Organization](https://github.com/KnpLabs) on GitHub. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request. :shipit:
:+1: First of all, thanks for contributing! The team is happy to help if you have any questions. Have a look to this contributing guide and also to the [FAQ section](https://github.com/KnpLabs/snappy/blob/master/doc/faq.md). :feet:
The following is a set of guidelines for contributing to Snappy, which is hosted by the [KNP Labs Organization](https://github.com/KnpLabs) on GitHub. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document opening a pull request. :shipit:
## Code of Conduct
This project and everyone participating in it is governed by the following [Code of Conduct](https://github.com/KnpLabs/snappy/blob/master/CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code.

@alexpozzi alexpozzi changed the title [WIP] added code of conduct and link to it in contributing file Added code of conduct and link to it in contributing file Jan 31, 2020
@alexpozzi alexpozzi merged commit d7ad8d5 into master Jan 31, 2020
@alexpozzi alexpozzi deleted the doc/contributing branch January 31, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants