Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly implement LoggerAwareInterface #383

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Explicitly implement LoggerAwareInterface #383

merged 1 commit into from
Jan 10, 2020

Conversation

jmsfwk
Copy link
Contributor

@jmsfwk jmsfwk commented Jan 10, 2020

I've explicity implemented LoggerAwareInterface on classes that have the setLogger(LoggerInterface $logger) method.

This will allow a DI container to automatically inject a logger.

(Updated version of #364)

alexpozzi
alexpozzi approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@alexpozzi alexpozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@alexpozzi alexpozzi merged commit 218c087 into KnpLabs:master Jan 10, 2020
@jmsfwk jmsfwk deleted the logger-aware branch January 10, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpozzi alexpozzi alexpozzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmsfwk @alexpozzi