[bugfix] Invalid results count #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was invalid results count fetched when Doctrine's CountOutputWalker used. CountOutputWalker is Query::HINT_CUSTOM_OUTPUT_WALKER, but not just the CustomTreeWalker. So fixed it. But it is better to test on some other Doctrine versions (not 2.3.3 one) before merge.
Closed
|
@stloyd please merge it |
|
This code can't be merged, as base was changed, so rebase/rewrite is required. |
|
Here it is. |
leberknecht
pushed a commit
to leberknecht/knp-components
that referenced
this pull request
Sep 5, 2013
Rewrite/rebase of KnpLabs#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was invalid results count fetched when Doctrine's CountOutputWalker used.
CountOutputWalker is Query::HINT_CUSTOM_OUTPUT_WALKER, but not just the CustomTreeWalker.
So fixed it.
But it is better to test on some other Doctrine versions (not 2.3.3 one) before merge.