Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add age formatter #192

Merged
merged 1 commit into from
Aug 7, 2023
Merged

feat: add age formatter #192

merged 1 commit into from
Aug 7, 2023

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Aug 3, 2023

I add age formatter

Examples:

{# with filter: #}
Age: {{ user.birthdate|age }} <!-- Age: 30 years old -->

{# ... or use the equivalent function: #}
Age: {{ age(user.birthdate) }} <!-- Age: 30 years old -->

translations/time.en.xliff Outdated Show resolved Hide resolved
Copy link
Collaborator

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

This is a nice PR - but does it solve a complex enough problem to be in the library? I'm not sure...

@weaverryan
Copy link
Collaborator

Ha! Ok, now I see #190 - (I'm reading my notifications in reverse). Ok then - could you rebase for the translation conflict?

@seb-jean
Copy link
Contributor Author

seb-jean commented Aug 7, 2023

Ha! Ok, now I see #190 - (I'm reading my notifications in reverse). Ok then - could you rebase for the translation conflict?

@weaverryan, no problem 😄 ! It is resolved.

@weaverryan
Copy link
Collaborator

Thanks @seb-jean! Now we have yet MORE translations to collect from languages /cc @kbond

@weaverryan weaverryan merged commit e574cf4 into KnpLabs:main Aug 7, 2023
13 checks passed
@seb-jean seb-jean mentioned this pull request Aug 8, 2023
41 tasks
@seb-jean
Copy link
Contributor Author

seb-jean commented Sep 7, 2023

Hi @weaverryan and @kbond ,
Do you think it is possible to publish a new release with age formatter.
Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants