Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecation warning when using symfony/config > 4.2 #229

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Avoid deprecation warning when using symfony/config > 4.2 #229

merged 1 commit into from
Dec 12, 2018

Conversation

antograssiot
Copy link
Contributor

No description provided.

@antograssiot
Copy link
Contributor Author

failing tests doesn't seems related...

@akerouanton
Copy link
Contributor

@antograssiot I'll look into these tests failures. Thank you :)

@antograssiot
Copy link
Contributor Author

antograssiot commented Dec 6, 2018 •
edited
Loading

@NiR- I've fix the bulid except for hhvm reverted as it has been done in #230

@akerouanton
Copy link
Contributor

@antograssiot I merged #230. Could you rebase please?

@antograssiot
Copy link
Contributor Author

here you are @NiR- 😄

@akerouanton akerouanton merged commit 60411b0 into KnpLabs:master Dec 12, 2018
@akerouanton
Copy link
Contributor

Thank you @antograssiot :)

@antograssiot antograssiot deleted the patch-1 branch December 12, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patpilus patpilus patpilus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antograssiot @akerouanton @patpilus