Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against different Symfony versions #119

Merged
merged 6 commits into from
Nov 11, 2015
Merged

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Nov 9, 2015

No description provided.

"symfony/finder": ">=2.0.0",
"symfony/validator": ">=2.0.0",
"knplabs/knp-snappy": "*"
"symfony/framework-bundle": "~2.3|~3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<2.3 is no longer supported by Symfony, I don't think bundles should keep support for it.

@wouterj
Copy link
Contributor Author

wouterj commented Nov 9, 2015

Current failure is related to a bug in symfony: symfony/symfony#16508

@akovalyov
Copy link
Contributor

thanks @wouterj. I guess, we should wait until the fix is released, right?

@wouterj
Copy link
Contributor Author

wouterj commented Nov 11, 2015

@akovalyov Symfony is now fixed, can you please restart the failing Travis job?

@akovalyov
Copy link
Contributor

@wouterj done, travis is passing. Thank you for you contribution.

akovalyov added a commit that referenced this pull request Nov 11, 2015
Test against different Symfony versions
@akovalyov akovalyov merged commit efda38a into KnpLabs:master Nov 11, 2015
@wouterj wouterj deleted the patch-1 branch November 11, 2015 21:51
@wouterj
Copy link
Contributor Author

wouterj commented Nov 11, 2015

You're welcome @akovalyov :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants