Remove trailing comma from QuerySentence identifier. Fixes #120

Knio · Feb 20, 2021 · 3ab8516 · 3ab8516
1 parent 4527cf4
commit 3ab8516
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/pynmea2/_version.py b/pynmea2/_version.py
@@ -1 +1 @@
-__version__ = '1.15.0'
+__version__ = '1.16.0'
diff --git a/pynmea2/nmea.py b/pynmea2/nmea.py
@@ -232,7 +232,7 @@ def __init__(self, talker, listener, sentence_type):
         self.data = []
 
     def identifier(self):
-        return '%s%sQ,%s,' % (self.talker, self.listener, self.sentence_type)
+        return '%s%sQ,%s' % (self.talker, self.listener, self.sentence_type)
 
 
 class ProprietarySentence(NMEASentence):

diff --git a/test/test_pynmea.py b/test/test_pynmea.py
@@ -5,7 +5,7 @@
 
 
 def test_version():
-    version = '1.15.0'
+    version = '1.16.0'
     assert pynmea2.version == version
     assert pynmea2.__version__ == version
 
@@ -87,19 +87,24 @@ def test_nmea_util():
     assert pynmea2.nmea_utils.dm_to_sd('0') == 0.
     assert pynmea2.nmea_utils.dm_to_sd('12108.1') == 121.135
 
+
 def test_missing_latlon():
     data = '$GPGGA,201716.684,,,,,0,00,,,M,0.0,M,,0000*5F'
     msg = pynmea2.parse(data)
     print(msg)
     assert msg.latitude == 0.
 
+
 def test_query():
     data = 'CCGPQ,GGA'
     msg = pynmea2.parse(data)
     assert isinstance(msg, pynmea2.QuerySentence)
     assert msg.talker == 'CC'
     assert msg.listener == 'GP'
     assert msg.sentence_type == 'GGA'
+    msg = pynmea2.QuerySentence('CC', 'GP', 'GGA')
+    assert msg.render() == '$CCGPQ,GGA*2B'
+
 
 def test_slash():
     with pytest.raises(pynmea2.nmea.ParseError):