Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type stubs #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

willwill2will54
Copy link

@willwill2will54 willwill2will54 commented May 24, 2024

Adds type information to aid Mypy, Pyright and other type checkers. (Addresses #191)

I chose .pyi interface files so as not to interfere with the considerable effort I observed making the codebase compatible with early python versions.

I unfortunately omitted using typing for decorator use when uninitialised, as mypy is erroneously opinionated about overriding new with different return types. As a result, the following example case still raises a type error:

@div
def greeting(name):
    p('Hello %s' % name)
print(greeting('Bob'))

Happy to make modifications to the implementation if requested!

Missing annotations: using tags as decorator without initialisation.
@Knio
Copy link
Owner

Knio commented Nov 26, 2024

How can this be tested/maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants