Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuerystringParser: don't raise an AttributeError in __repr__ #30

Merged
merged 2 commits into from
May 4, 2021
Merged

QuerystringParser: don't raise an AttributeError in __repr__ #30

merged 2 commits into from
May 4, 2021

Conversation

andrew-d
Copy link
Collaborator

Fixes #29

@andrew-d andrew-d self-assigned this Sep 16, 2020
@andrew-d
Copy link
Collaborator Author

Hm, apparently forgot to do anything with this...
r? @tomchristie

tomchristie
tomchristie approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, yup.

Personally I would probably have any test case for __repr__ be something like `assert repr(self.p) == '...whatever...', but s'all good.

@andrew-d andrew-d merged commit ed8c47a into master May 4, 2021
@andrew-d andrew-d deleted the andrew/fix-attribute-error branch May 4, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees

@andrew-d andrew-d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is an AttributeError when repr(querystring_parser)
2 participants
@andrew-d @tomchristie