Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit python3.9 and 3.10 support #224

Merged
merged 2 commits into from
Jan 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: ['3.6', '3.7', '3.8', '3.9', '3.10']
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pytest-cov
black
flake8
starlette
quart; python_version == '3.7'
quart; python_version >= '3.7'
moto[server]
mypy
brotli
Expand Down
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,7 @@ def get_long_description():
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
],
)
8 changes: 2 additions & 6 deletions tests/test_lifespan.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
from mangum import Mangum
from mangum.exceptions import LifespanFailure

# One (or more) of Quart's dependencies does not support Python 3.8, ignore this case.
IS_PY38 = sys.version_info[:2] == (3, 8)
# Quart no longer support python3.6.
IS_PY36 = sys.version_info[:2] == (3, 6)

if not (IS_PY38 or IS_PY36):
if not IS_PY36:
from quart import Quart
else:
Quart = None
Expand Down Expand Up @@ -269,9 +268,6 @@ def homepage(request):
}


@pytest.mark.skipif(
IS_PY38, reason="One (or more) of Quart's dependencies does not support Python 3.8."
)
@pytest.mark.skipif(IS_PY36, reason="Quart does not support Python 3.6.")
@pytest.mark.parametrize(
"mock_aws_api_gateway_event", [["GET", None, None]], indirect=True
Expand Down