Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to brotli compress #140

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Add support to brotli compress #140

merged 2 commits into from
Sep 30, 2020

Conversation

fullonic
Copy link
Contributor

This PR fixes #139.
It adds a new test based on the gzip test, where the only change is the compress algorithm library from gzip to brotli.

@fullonic fullonic mentioned this pull request Sep 29, 2020
@kylebarron
Copy link
Contributor

Looks like tests are failing because you need to reformat with black

@jordaneremieff
Copy link
Collaborator

Nice work, thanks for adding the support! This is really cool to see how easy it is to extend the current behaviour. 👍

@jordaneremieff jordaneremieff merged commit 7874f70 into Kludex:main Sep 30, 2020
@fullonic
Copy link
Contributor Author

Great!! Yep, it was easy to point what as necessary to change and implement to get support for brotli. Happy to help :)

@kylebarron
Copy link
Contributor

Thanks for the merge @jordaneremieff ! Do you have any timeline for a new patch or minor release?

@jordaneremieff
Copy link
Collaborator

@kylebarron I'll try to release this weekend.

four43 pushed a commit to four43/mangum that referenced this pull request Mar 27, 2021
* Add support to brotli compress
four43 pushed a commit to four43/mangum that referenced this pull request Aug 20, 2021
* Add support to brotli compress
khamaileon pushed a commit to khamaileon/mangum that referenced this pull request Jan 13, 2024
* Add support to brotli compress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brotli Support
3 participants