This repository has been archived by the owner on Dec 8, 2020. It is now read-only.
fix for not lowering portfolio value #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
events/models.py
Outdated
| bet.user.save() | ||
| # This cause display event in "latest outcome" | ||
| bet.is_new_resolved = True | ||
| bet.save() | ||
| # always -- portfolio_value | ||
| for transaction in Transaction.objects.filter(event=self): |
There was a problem hiding this comment.
Should be for user in UsersPortfolio loop, it will be more efficient. And I'm not sure is this correct calculation?
There was a problem hiding this comment.
True story. Going to check it
There was a problem hiding this comment.
Do you mean this:
for transaction in Transaction.objects.filter(event=self).values('user'):
user = UserProfile.objects.get(pk=transaction['user'])
user.portfolio_value = user.current_portfolio_value
user.save()
???
| # always -- portfolio_value | ||
| from accounts.models import UserProfile | ||
| for user in UserProfile.objects.filter(transaction__event=self): | ||
| user.portfolio_value = user.current_portfolio_value |
There was a problem hiding this comment.
In worst case scenario it's bet.has * bet.bought_avg_price ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not RTM