-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resonance_tester: Fix chips selection, add accel_per_hz selection #6726
Conversation
Every commit is expected to have a sign-off line. Also, take a look at: https://www.klipper3d.org/CONTRIBUTING.html Thanks. |
e9ff1b9
to
c295ab0
Compare
Thanks for the tip, I think I fixed the formatting of the commits |
Thanks. I think this makes sense. However, given that this is a not a backwards-compatible change, I think it should be mentioned in |
Do you want me to add a straight |
I think the G-Codes documentation is OK already. But since this is a change that will break any existing usages of |
Corrected issue where accelerometer names were incorrectly prefixed with "adxl345", preventing the selection of other chip types when running TEST_RESONANCES. Signed-off-by: Maksim Bolgov maksim8024@gmail.com
Implemented support for selecting the `accel_per_hz` parameter when running TEST_RESONANCES. Signed-off-by: Maksim Bolgov maksim8024@gmail.com
…rs and bracket corrections Signed-off-by: Maksim Bolgov maksim8024@gmail.com
Thanks! |
Thanks. -Kevin |
…ipper3d#6726) Corrected issue where accelerometer names were incorrectly prefixed with "adxl345", preventing the selection of other chip types when running TEST_RESONANCES. Implemented support for selecting the `accel_per_hz` parameter when running TEST_RESONANCES. docs: Update TEST_RESONANCES + SHAPER_CALIBRATE with missing parameters and bracket corrections Signed-off-by: Maksim Bolgov <maksim8024@gmail.com>
…ipper3d#6726) Corrected issue where accelerometer names were incorrectly prefixed with "adxl345", preventing the selection of other chip types when running TEST_RESONANCES. Implemented support for selecting the `accel_per_hz` parameter when running TEST_RESONANCES. docs: Update TEST_RESONANCES + SHAPER_CALIBRATE with missing parameters and bracket corrections Signed-off-by: Maksim Bolgov <maksim8024@gmail.com>
-The current code does not have the option to "live" select a non-adxl345
chips
when runningTEST_RESONANCES
, since it adds the adxl prefix by default.-Added the ability to "live" select
accel_per_hz
when runningTEST_RESONANCES
.-Minor fixes in the documentation.
Signed-off-by: Maksim Bolgov maksim8024@gmail.com