Warning Fix: Current code produces warnings for possible value overflows. #6665
Conversation
|
Thanks. The change looks fine, but commits need to have a signed-off-by line - see https://www.klipper3d.org/CONTRIBUTING.html . Also, fwiw, the issue isn't with uint8_t as C will implicitly convert most operations to an Cheers, |
Was there a different issue? |
|
Sorry, I missed that the signed-off-by line was in fact present in the commit message. Just for completeness, can you provide the signed-off-by line with the correct spelling? -Kevin |
As the input values are uint8_t types, any shift may result in value loss. Explicit promotion to the output type (uint32_t) keeps things safe. Have also changed the int32_t in ads1220_read_adc to uint32_t, type promotion and bit manipulation are a bit 'weird' on signed integers, so keep it as an unsigned to align with following function call parameter type. Have retained the prior explicit sign extension logic however. Signed-off-by: Bevan Weiss <[email protected]>
bevanweiss
force-pushed
the
fix_shift_warnings
branch
from
71a69e8 to
350412e
Compare
Done, thanks |
|
Thanks. -Kevin |
…ipper3d#6665) As the input values are uint8_t types, any shift may result in value loss. Explicit promotion to the output type (uint32_t) keeps things safe. Have also changed the int32_t in ads1220_read_adc to uint32_t, type promotion and bit manipulation are a bit 'weird' on signed integers, so keep it as an unsigned to align with following function call parameter type. Have retained the prior explicit sign extension logic however. Signed-off-by: Bevan Weiss <[email protected]>
…ipper3d#6665) As the input values are uint8_t types, any shift may result in value loss. Explicit promotion to the output type (uint32_t) keeps things safe. Have also changed the int32_t in ads1220_read_adc to uint32_t, type promotion and bit manipulation are a bit 'weird' on signed integers, so keep it as an unsigned to align with following function call parameter type. Have retained the prior explicit sign extension logic however. Signed-off-by: Bevan Weiss <[email protected]>
As the input values are uint8_t types, any shift may result in value loss.
Explicit promotion to the output type (uint32_t) keeps things safe.
Have also changed the int32_t in ads1220_read_adc to uint32_t, type promotion and bit manipulation are a bit 'weird' on signed integers, so keep it as an unsigned to align with following function call parameter type.
Have retained the prior explicit sign extension logic however.