-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sht3x: use periodic report mode #6634
Conversation
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line. Thanks |
fc9e005
to
e469f16
Compare
Thanks. Happy to commit this when you are ready. Note, though, that host based There are a variety of ways to fix this. I'd guess the simplest would be to add an -Kevin |
I'm not an experienced embedded developer, so I write pauses according to the datasheet with some additional sane margin "just in case". In HTU code they all look like x10 of max datasheet values, maybe because reactor pause does not guarantee timings? With that said:
Thanks |
Signed-off-by: Timofey Titovets <[email protected]>
Signed-off-by: Timofey Titovets <[email protected]>
e469f16
to
aa59e32
Compare
Thanks. I committed this change. The -Kevin |
Signed-off-by: Timofey Titovets <[email protected]>
SHT3X supports periodic mode, which allows us to completely skip the "write" phase and wait, and just read data in one command.
Also, I corrected reactor pauses to the right numeric order (they are also wrong in htu21.py).
Thanks.