-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_status() method to screws_tilt_adjust #5921
Add get_status() method to screws_tilt_adjust #5921
Conversation
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
Thanks. In general it seems fine to me. As a high-level comment though, have some keys missing from a dictionary is really annoying to deal with - might be better to just add dummy @matthewlloyd - do you have any comments on this? -Kevin |
Signed-off-by: Christopher Meredith <[email protected]>
Thanks. I went ahead and added the dummy values. |
Thanks. -Kevin |
Hi @theophile, thank you for your work on this! I didn't notice this PR at the time, but as I am looking into adding support for this in Fluidd and I wonder if instead of suffixing As it stands "base" is an English word yet the names of the screws can be whatever users want to call them, but having a boolean would allow the UI's (and macro's) to better handle the "base" screw. What do you think of this? |
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
This reverts commit 99caf52.
This reverts commit 99caf52.
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
Signed-off-by: Christopher Meredith <[email protected]>
This is a resubmission of my earlier PR #4634 with additional work to fix the previously identified whitespace issues and to add the required documentation. Here's the explanation from the original PR:
This adds a get_status() method to the screws_tilt_adjust.py module so that gcode macros and menu elements can read the results from the
screws_tilt_calculate
command. This creates a newprinter.screws_tilt_adjust
object with two properties:error
: False by default, but True if thescrews_tilt_calculate
command triggered the "bed level exceeds configured limits" error.results
: Until thescrews_tilt_calculate
command is run, this is an empty python list. But oncescrews_tilt_calculate
has completed successfully, this is a list containing a python dictionary for each configured bed screw. Each of those dictionaries contains the following keys:01:15
for one full turn plus a quarter turn)*The dictionary for the "base" screw does not have the sign or adjust keys because the calculation assumes the base screw will not be adjusted.
I have successfully used this new get_status() method together with a handful of macros, custom menus, display groups, and even a couple of custom glyphs to enable Z-probe bed tramming directly from the printer LCD, with a rudimentary GUI and everything.