Deprecate "NTC 100K beta 3950" thermistor #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinOConnor
force-pushed
the
work-temps-20211101
branch
from
347ec50 to
f6bda92
Compare
|
After a little further thought, I think "Generic 3950" is probably a better name than "RepRap 3950". I have updated this PR accordingly. -Kevin |
|
I am curious when this will be released? |
KevinOConnor
force-pushed
the
work-temps-20211101
branch
from
f6bda92 to
a4cd914
Compare
Move the default list of sensor modules from heaters.py to a new temperature_sensors.cfg config file. Signed-off-by: Kevin O'Connor <[email protected]>
Move the definitions of the default thermistors from thermistors.py to the temperature_sensors.cfg file. Signed-off-by: Kevin O'Connor <[email protected]>
Signed-off-by: Kevin O'Connor <[email protected]>
KevinOConnor
force-pushed
the
work-temps-20211101
branch
from
a4cd914 to
d2891c1
Compare
It seems the common "beta 3950" thermistors generally follow a temperature table defined by the new "Generic 3950" definition. Using a table that actually follows the "beta 3950" temperature curve is generally less accurate. Deprecate the existing "NTC 100K beta 3950" definition to avoid this common issue. Signed-off-by: Kevin O'Connor <[email protected]>
KevinOConnor
force-pushed
the
work-temps-20211101
branch
from
d2891c1 to
c179db3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the default thermistor definitions from thermistor.py to a new temperature_sensor.cfg file, introduces a new "Generic 3950" thermistor, and deprecates the "NTC 100K beta 3950" definition.
As discussed in #4054 , it seems most real-world "beta 3950" sensors don't actually follow a true "beta 3950" temperature curve, and instead follow a curve defined in the new "Generic 3950" table. Deprecating the "NTC 100K beta 3950" definition seems like the best way to raise awareness and move printers over to a more accurate configuration.
-Kevin
Edit: Change name of new thermistor to "Generic 3950".