Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore first probe value #3397

Closed
Makhaira opened this issue Oct 4, 2020 · 5 comments
Closed

Add ability to ignore first probe value #3397

Makhaira opened this issue Oct 4, 2020 · 5 comments
Labels

Comments

@Makhaira
Copy link

Makhaira commented Oct 4, 2020

I have seen a number of reports across different printers and different probes where the first probe result of a "set" is inaccurate compare to the rest of the set of results. It would be great if there was a config variable in klipper where you could choose to ignore the first result in a probe.

E.G.

probe returns result of 0.2, 0.19, 0.19, 0.19, 0.19.

I am asking for klipper to ignore the first result in any subsequent calculations, the dataset becomes just 0.19, 0.19, 0.19, 0.19. This has the potential to remove the number of repeat probes required as there is confidence the first result is ignored.

@klipper-gitissuebot
Copy link

Hi @Makhaira,

It did not look like there was a Klipper log file attached to this ticket. The log file has been engineered to answer common questions the Klipper developers have about the software and its environment (software version, hardware type, configuration, event timing, and hundreds of other questions).

Unfortunately, too many people have opened tickets without providing the log. That consumes developer time; time that would be better spent enhancing the software. If this ticket references an event that has occurred while running the software then the Klipper log must be attached to this ticket. Otherwise, this ticket will be automatically closed in a few days.

For information on obtaining the Klipper log file see: https://github.com/KevinOConnor/klipper/blob/master/docs/Contact.md

The log can still be attached to this ticket - just add a comment and attach the log to that comment.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@Sineos
Copy link
Collaborator

Sineos commented Oct 5, 2020

You can use the median function instead of average. IMO the best approach is to use an even number of probes, as the median function will average around the middle.

For example:
0.18, 0.19, 0.21, 0.22
will discard 0.18 and 0.22 and average 0.19 and 0.21

@Makhaira
Copy link
Author

Makhaira commented Oct 7, 2020 via email

@github-actions
Copy link

Hello,

It looks like there hasn't been any recent updates on this
Klipper github issue. If you created this issue and no
longer consider it open, then please login to github and
close the issue. Otherwise, if there is no further activity
on this thread then it will be automatically closed in a few
days.

Best regards,

~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@Makhaira
Copy link
Author

Will use median on even number probe

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants