Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auto-compounder button #2397

Merged
merged 2 commits into from
Nov 22, 2024
Merged

add auto-compounder button #2397

merged 2 commits into from
Nov 22, 2024

Conversation

0xMakka
Copy link
Collaborator

@0xMakka 0xMakka commented Nov 21, 2024 •
edited
Loading

Description

  • Remove base logo from buttons and group under a title Base Network and logo (open to suggestions on this if we want to change it).
  • Fix the squid router link - was previously pointing to v2 which no longer exists.

Screenshot

Screenshot 2024-11-21 at 14 24 03

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 9:03pm
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 9:03pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 9:03pm

@jabby09 jabby09 self-assigned this Nov 21, 2024
jabby09
jabby09 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jabby09 jabby09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xMakka looks good
autocompounder option 404s at the moment but I assume that will fix itself when we deploy the app

@0xMakka
Copy link
Collaborator Author

0xMakka commented Nov 21, 2024

@0xMakka looks good autocompounder option 404s at the moment but I assume that will fix itself when we deploy the app

Yep @jabby09 - currently not showing because auto-compounder route doesn't exist on prod, but as soon as it's released this button will link to it.

@Atmosfearful Atmosfearful merged commit 059f2d9 into staging Nov 22, 2024
5 checks passed
@Atmosfearful Atmosfearful deleted the makka/add-autocompounder-button branch November 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabby09 jabby09 jabby09 approved these changes

@Atmosfearful Atmosfearful Awaiting requested review from Atmosfearful

@must-be-carbon must-be-carbon Awaiting requested review from must-be-carbon

Assignees

@jabby09 jabby09

Labels
QA done
Projects
Sprint Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xMakka @jabby09 @Atmosfearful