-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: migrate utils to ethers v6 and replace BigNumber with bigint #2233
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR.
Can you just check that logging in still works in carbonmark before merging?
Tests do not cover the verifyProfileSignature
function.
I tried the to login and still works |
@sidneyarida this is good to go once you resolve the conflicts |
# Conflicts: # carbonmark-api/package.json # carbonmark-api/src/routes/purchases/get.utils.ts # carbonmark-api/src/routes/users/[walletOrHandle]/get.ts # carbonmark-api/src/utils/helpers/activities.utils.ts # carbonmark-api/src/utils/marketplace.utils.ts
Description
#1425
Migration of utils functions and BigNumber to ether-v6 in carbonmark-api folder
Related Ticket
Closes
Also related to
How to Test
Notes For QA
Specific pages, components or journeys that might be affected:
Relevant preview URLs:
Other notes: