Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NBO default pool project in the API #2225

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Fix NBO default pool project in the API #2225

merged 4 commits into from
Feb 1, 2024

Conversation

biwano
Copy link
Collaborator

@biwano biwano commented Feb 1, 2024 •
edited
Loading

Description

  • Changes NBO default pool project in the API
  • Also adds logging on fetch errors to troubleshoot Vercel deployment issues

Related Ticket

Related to #2091
Related to #2224

How to Test

  1. curl https://carbonmark-api-git-biwano-fix2091apipoolproject-klimadao.vercel.app/projects/VCS-875-2015
  2. Check isPoolDefault is true for nbo

Notes For QA

  • This PR is low-risk or narrow in scope, QA is not needed.

@biwano biwano deployed to Preview – carbonmark-api February 1, 2024 10:39 — with GitHub Actions Active
@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview Feb 1, 2024 11:20am
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 1, 2024 11:20am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 11:20am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 11:20am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
carbon ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 11:20am

@biwano biwano deployed to Preview – carbonmark-api February 1, 2024 10:41 — with GitHub Actions Active
@biwano biwano force-pushed the biwano/fix/2091_api_pool_project branch from 72780b7 to e9dd585 Compare February 1, 2024 10:42
@biwano biwano deployed to Preview – carbonmark-api February 1, 2024 10:42 — with GitHub Actions Active
@biwano biwano deployed to Preview – carbonmark-api February 1, 2024 11:04 — with GitHub Actions Active
@biwano biwano marked this pull request as ready for review February 1, 2024 11:09
@biwano biwano requested a review from 0xemc as a code owner February 1, 2024 11:09
@biwano biwano force-pushed the biwano/fix/2091_api_pool_project branch from d2b2080 to 8822dcb Compare February 1, 2024 11:16
@biwano biwano deployed to Preview – carbonmark-api February 1, 2024 11:16 — with GitHub Actions Active
@biwano biwano mentioned this pull request Feb 1, 2024
Merged
@biwano biwano merged commit 7d6a669 into staging Feb 1, 2024
10 checks passed
@biwano biwano deleted the biwano/fix/2091_api_pool_project branch February 1, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xemc 0xemc 0xemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biwano @0xemc