-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Polygon-bridged-carbon replaced by polygon-digital-carbon #2047
Merged
Atmosfearful
merged 2 commits into
staging
from
API_tufnel/update-subgraph-for-retirement-data
Jan 4, 2024
Merged
[API] Polygon-bridged-carbon replaced by polygon-digital-carbon #2047
Atmosfearful
merged 2 commits into
staging
from
API_tufnel/update-subgraph-for-retirement-data
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psparacino
requested review from
Atmosfearful,
0xemc,
0xMakka,
biwano and
sprrwhwk
as code owners
December 19, 2023 21:30
psparacino
deployed
to
Preview – carbonmark-api
December 19, 2023 21:30 — with
GitHub Actions
Active
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
psparacino
force-pushed
the
API_tufnel/update-subgraph-for-retirement-data
branch
from
December 19, 2023 21:36
d5a3fc3
to
5e4e333
Compare
psparacino
deployed
to
Preview – carbonmark-api
December 19, 2023 21:36 — with
GitHub Actions
Active
psparacino
force-pushed
the
API_tufnel/update-subgraph-for-retirement-data
branch
from
December 20, 2023 00:44
5e4e333
to
62a3933
Compare
psparacino
deployed
to
Preview – carbonmark-api
December 20, 2023 00:44 — with
GitHub Actions
Active
psparacino
changed the title
API: Polygon-bridged-carbon replaced by polygon-digital-carbon
[API] Polygon-bridged-carbon replaced by polygon-digital-carbon
Dec 20, 2023
psparacino
force-pushed
the
API_tufnel/update-subgraph-for-retirement-data
branch
from
December 20, 2023 02:54
62a3933
to
75e5e82
Compare
psparacino
deployed
to
Preview – carbonmark-api
December 20, 2023 02:54 — with
GitHub Actions
Active
psparacino
force-pushed
the
API_tufnel/update-subgraph-for-retirement-data
branch
from
December 20, 2023 03:37
75e5e82
to
e2bfb2a
Compare
psparacino
deployed
to
Preview – carbonmark-api
December 20, 2023 03:39 — with
GitHub Actions
Active
psparacino
force-pushed
the
API_tufnel/update-subgraph-for-retirement-data
branch
from
December 20, 2023 03:41
e2bfb2a
to
4c870a6
Compare
psparacino
deployed
to
Preview – carbonmark-api
December 20, 2023 03:42 — with
GitHub Actions
Active
0xemc
approved these changes
Dec 20, 2023
biwano
reviewed
Dec 21, 2023
psparacino
force-pushed
the
API_tufnel/update-subgraph-for-retirement-data
branch
from
December 21, 2023 16:27
0ec17c0
to
6b2c2e4
Compare
psparacino
deployed
to
Preview – carbonmark-api
December 21, 2023 16:27 — with
GitHub Actions
Active
Atmosfearful
deployed
to
Preview – carbonmark-api
January 4, 2024 01:18 — with
GitHub Actions
Active
Atmosfearful
deleted the
API_tufnel/update-subgraph-for-retirement-data
branch
January 4, 2024 01:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polygon-bridged carbon is deprecated and needs to be replaced everywhere by polygon-digital-carbon. The only instance left was used to retrieve retirement data for
retirements/
.Related to [App] digital-carbon integration for retirement data PR #2048
All the actual fetch currently takes place in
carbonmark/
. The retirement receipt in the ICR PR is dependent on this PR i.e. this PR should be merged before PR #will fill in once PR is created
As a
retirements/
endpoint is the ultimate goal, this is an interim solution to removebridged-carbon
and not block the ICR merge.Related Ticket
Closes #1938
Notes For QA
Specific pages, components or journeys that might be affected:
Relevant preview URLs:
Other notes: